fix(asciidoc): fix empty cell handling#3664
Open
ceberam wants to merge 3 commits into
Open
Conversation
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Contributor
|
✅ DCO Check Passed Thanks @ceberam, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
ceberam
added
asciidoc
cau-git
previously approved these changes
Jun 19, 2026
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Successfully implemented and tested the fix for empty table cells in AsciiDoc backend, improved the test infrastructure, and renamed test files to follow project conventions.
Resolves #3663
Changes Completed
1. Empty Cell Fix (
docling/backend/asciidoc_backend.py)_parse_table_line()to preserve empty cells2. Test Infrastructure Improvements (
tests/test_backend_asciidoc.py)GEN_TEST_DATAflag supportverify_export()utility like other backends3. Comprehensive Test Cases (
tests/data/asciidoc/asciidoc_02.asciidoc)4. File Renaming (Following Project Convention)
test_*.asciidoc→asciidoc_*.asciidoc